add handlers for dynamic registration #114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the core will require asgiref for this, but it's not in the dependencies. Is there a more generic sync_to_async() than using a Django library? |
|
@hmoffatt whoops, you're right! It's easy enough to remove async, so I've just done that. |
|
I would love it for this PR to be merged. Is there any chance it will ever be reviewed @dmitry-viskov? Is there anything I could do to help get this merged? |
christianp
force-pushed
the
dynamic-registration
branch
from
77749f5 to
bce8d06
Compare
They're automatically generated, so I don't think we need to lint them.
Apparently pylint wants you to get BaseException and Exception from builtins
As well as formatting changes, there are a few methods which pylint said had too many positional arguments, so I've changed them to keyword arguments. Anything using those methods will have to make sure the keyword arguments are named.
christianp
force-pushed
the
dynamic-registration
branch
from
bce8d06 to
b710537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #70.
See https://github.com/christianp/pylti1.3-django-example/tree/dynamic-registration for an example.
I've tried to add support for dynamic registration in a way that matches the rest of the package. I haven't written any unit tests or run pylint yet - I thought I'd ask for your opinion on the implementation before working out how to do that.