Skip to content

Conversation

christianp
Copy link

@christianp christianp commented Feb 20, 2023

Resolves #70.

See https://github.com/christianp/pylti1.3-django-example/tree/dynamic-registration for an example.

I've tried to add support for dynamic registration in a way that matches the rest of the package. I haven't written any unit tests or run pylint yet - I thought I'd ask for your opinion on the implementation before working out how to do that.

@hmoffatt
Copy link
Contributor

It looks like the core will require asgiref for this, but it's not in the dependencies.

Is there a more generic sync_to_async() than using a Django library?

@christianp
Copy link
Author

@hmoffatt whoops, you're right! It's easy enough to remove async, so I've just done that.

@yunusdemir
Copy link

I would love it for this PR to be merged. Is there any chance it will ever be reviewed @dmitry-viskov? Is there anything I could do to help get this merged?

They're automatically generated, so I don't think we need to lint them.
Apparently pylint wants you to get BaseException and Exception from builtins
As well as formatting changes, there are a few methods which pylint said had too many positional arguments, so I've changed them to keyword arguments.

Anything using those methods will have to make sure the keyword arguments are named.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support Dynamic Registration

3 participants